Conversation
Conflicts: CMake/fletch-tarballs.cmake
Conflicts: CMake/fletch-tarballs.cmake
|
Can one of the admins verify this patch? |
|
You can... talk? |
Conflicts: CMake/External_VXL.cmake
Conflicts: CMake/External_VXL.cmake
Conflicts: Patches/VXL/FindFFMPEG.cmake
|
If this patch fixes the upstream VXL's ffmpeg issue then please push it there instead of making a fletch patch. I can approve and merge VXL branches so I would prefer not patching locally. |
|
jenkins test this please |
| @@ -0,0 +1,606 @@ | |||
| // This is core/vidl/vidl_ffmpeg_ostream_v56.hxx | |||
There was a problem hiding this comment.
Is this a new file or patched from VXL source? If it's patched, it would be ideal to add in 2 commits so we can see the actual diff
|
Having looked at the diff in the VXL patch, is there a good reason we don't push this into that repo? Also, why don't we go closer to master? Is something else broken? |
|
Something else was broken on latest VXL in the time period of this branch though that's fairly old now so maybe it was fixed, haven't had a chance to look at this in more detail and this branch is still broken on Windows due to a bug in VXL's build sys |
|
Jenkins test this please |
|
I have been testing recently and currently master fails on VS with link errors. |
4 participants
VXL update was required for the ITK version